Change livesync dir permissions on device even if app is not restarted #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyosifov
approved these changes
Apr 12, 2017
rosen-vladimirov
approved these changes
Apr 12, 2017
rosen-vladimirov
force-pushed
the
pete/chmod-livesync-dirs-android
branch
from
cea8aca to
be29b81
Compare
|
+1 |
|
Merging as the problem is in the tests. Approved by @dtopuzov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue in android-runtime: NativeScript/android#591
Changing .css and .xml files in a NativeScript project would not change permissions in the temporary sync dir on the device. This could result in showing outdated views on subsequent installs of the application on the same device without using the CLI's livesync service.
The proposed changes will always chmod 777 the sync directory, thus allowing the runtime to remove any previous livesync artifacts.
Relies on changes made in telerik/mobile-cli-lib#943