Plamen5kov/use xcodebuild instead of xcrun #2678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing change in xcode 8.3
dtopuzov
approved these changes
Mar 31, 2017
|
run ci |
lib/services/ios-project-service.ts
Outdated
| ]; | ||
| await this.$childProcess.spawnFromEvent("xcodebuild", args, "exit", | ||
| { stdio: buildConfig.buildOutputStdio || 'inherit', cwd: this.getPlatformData(projectData).projectRoot }, | ||
| { emitOptions: { eventName: constants.BUILD_OUTPUT_EVENT_NAME }, throwError: false }); |
There was a problem hiding this comment.
shouldn't throwError be true here?
There was a problem hiding this comment.
@rosen-vladimirov Not sure, we've set this in the other spawn. I wanted to keep the flags the same?
There was a problem hiding this comment.
@yyosifov this has been a mistake - it should be true whenever we want to break the operation (i.e. the next operation has no meaning in case this one fails)
lib/services/ios-project-service.ts
Outdated
| /** | ||
| * Exports .xcarchive for AppStore distribution. | ||
| */ | ||
| public async exportDevelopmentArchive(projectData: IProjectData, buildConfig: IBuildConfig, options: { archivePath: string, exportDir?: string, teamID?: string }): Promise<string> { |
There was a problem hiding this comment.
if it's public, it should be added to the interface
There was a problem hiding this comment.
@rosen-vladimirov This doesn't have to be public
…to true on xcodebuild
|
@rosen-vladimirov you can have another look, please :) |
rosen-vladimirov
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xccrun PackageApplication is now deprecated in XCode 8.3, therefore we're switching to xcodebuild and execute two steps:
.xarchiveto.iparelated issue: #2668