Skip to content

Fix watch incorrectly being overrided by justlaunch always #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

yyosifov
Copy link
Contributor

The Watch Option was completely overriden by the Justlaunch option, every time. This is a newly introduced issue. Now, the justlaunch will take precedence if it's set to true and the watch will be set to false in this case, no matter what's passed for watch.

@Plamen5kov
Copy link
Contributor

@yyosifov what's the case --justlaunch isn't working as expected?
I tried running: tns run android --justlaunch and the console is interrupted as expected.

@yyosifov
Copy link
Contributor Author

@Plamen5kov Justlaunch is working as expected. What happened is that someone set watch = !justlaunch which means that if I say --no-watch it still will be set to the value of justlaunch, which by default is false.

@yyosifov yyosifov merged commit d50c3a4 into master Mar 29, 2017
@etabakov etabakov deleted the yosifov/fix-no-watch-option branch March 29, 2017 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants