Skip to content

skip the hidden files when livesyncing #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2017
Merged

Conversation

yyosifov
Copy link
Contributor

Add filter for files which are hidden in linux/Mac to be skipped when livesync-ing the app. Some IDEs create them to backup the currently edited file and this causes a re-deploy/re-run of the Application although it's not necessary.

@yyosifov yyosifov changed the title Yosifov/fix hidden files copy skip the hidden files when livesyncing Mar 27, 2017
@Plamen5kov Plamen5kov self-requested a review March 28, 2017 06:11
Copy link
Contributor

@Plamen5kov Plamen5kov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform-livesync-service.ts is not used by nativescript-cli. So we'll never use this functionality during livesync.

@rosen-vladimirov
Copy link
Contributor

@Plamen5kov platformLiveSyncService is the correct service used by NativeScript CLI:
https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/livesync/livesync-service.ts#L82

@Plamen5kov
Copy link
Contributor

@rosen-vladimirov I debugged it and not one method is called from this service.

@yyosifov
Copy link
Contributor Author

@Plamen5kov Sure, we can debug together then :)

@Plamen5kov
Copy link
Contributor

Plamen5kov commented Mar 28, 2017

My bad, debugging was broken on my machine.
After testing: works as expected.

@yyosifov yyosifov merged commit 8a7e798 into master Mar 28, 2017
@pkoleva pkoleva deleted the yosifov/fix-hidden-files-copy branch March 31, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants