Fix ios-device-operations dispose #2662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Mar 27, 2017
lib/commands/debug.ts
Outdated
| $platformsData: IPlatformsData) { | ||
|
|
||
| $platformsData: IPlatformsData, | ||
| private $iosDeviceOperations: IIOSDeviceOperations) { |
There was a problem hiding this comment.
why is this private? It's used only in constructor
TsvetanMilanov
changed the title
TomaNikolov
force-pushed
the
milanov/fix-ios-device-operations-dispose
branch
2 times, most recently
from
ab8752c to
8af206d
Compare
We need to check if the justlaunch flag is passed before we set the should dispose property to false. If we set it to false unconditionally when we pass justlaunch flag the process will never exit.
|
is this fix going to be back ported to 2.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to check if the justlaunch flag is passed before we set the should dispose property to false. If we set it to false unconditionally when we pass justlaunch flag the process will never exit.
Fixes #2654