Fix hooks execution when using CLI as lib and fix package.json #2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitko-Kerezov
approved these changes
Mar 17, 2017
rosen-vladimirov
force-pushed
the
vladimirov/prepare-for-cloud-builds
branch
from
84b85d7 to
d6696a1
Compare
|
run ci |
When NS CLI is used as library, project hooks are not executed as hooksService gets the project dir from `$options` or current working dir. Fix this by getting the projectDir from the hookArgs object. The object is constructed from method parameters. We check if there's `projectDir` or `projectData.projectDir` arg. Also fix the caching of hooks - each time when we try to execute them, we'll search the directories for hooks. This is required for long living process. Additionally use semver's package definitions from `@types` repo. Rename two `.d.ts` files which were incorrectly set as `.ts`.
rosen-vladimirov
force-pushed
the
vladimirov/prepare-for-cloud-builds
branch
from
d6696a1 to
f5e6af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NS CLI is used as library, project hooks are not executed as hooksService gets the project dir from
$optionsor current working dir.Fix this by getting the projectDir from the hookArgs object. The object is constructed from method parameters. We check if there's
projectDirorprojectData.projectDirarg.Also fix the caching of hooks - each time when we try to execute them, we'll search the directories for hooks. This is required for long living process.
Additionally use semver's package definitions from
@typesrepo.Rename two
.d.tsfiles which were incorrectly set as.ts.Add zipstream package - it's used in
$fs.zipFilesmethod, but somehow it's missing from this package.json, so trying to use the mentioned method fails