Fix iOS device log filter #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsvetanMilanov
force-pushed
the
milanov/fix-device-log-filter
branch
from
a84760e to
1b3d5c4
Compare
rosen-vladimirov
approved these changes
Mar 16, 2017
TsvetanMilanov
force-pushed
the
milanov/fix-device-log-filter
branch
from
1b3d5c4 to
718e4e7
Compare
We need to pass the project directory only for the ios-log-filter in the NS CLI. That's why we can use the projectData instead of adding it as a parameter.
TsvetanMilanov
force-pushed
the
milanov/fix-device-log-filter
branch
from
718e4e7 to
6cd04a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass the project directory only for the ios-log-filter in the NS CLI. That's why we can use the projectData instead of adding it as a parameter.
Common lib reference: telerik/mobile-cli-lib#905