Move tns related code to common #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
|
|
||
| tnsIosPackage = path.resolve(options.frameworkPath); | ||
| } else { | ||
| tnsIosPackage = this.$npm.install("tns-ios").wait(); |
There was a problem hiding this comment.
Not a merge stopper. This is a very lengthly operation. Can we warn the user to be patient?
|
Looks good. 👍 but consider my remark for a future pull request. |
Fatme
force-pushed
the
fatme/remove-tns-releated-code-from-common
branch
from
c0bd22e to
4610aed
Compare
|
Test PASSed. |
Fatme
pushed a commit
that referenced
this pull request
Feb 27, 2015
…ode-from-common Move tns related code to common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.