Skip to content

take last parameter of id for packageName #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

Plamen5kov
Copy link
Contributor

problem:
We needed id set in package.json to be exactly 3 components long.

solution
Take the last component of the id instead of the third one.

@Plamen5kov Plamen5kov self-assigned this Mar 9, 2017
@vchimev
Copy link

vchimev commented Mar 9, 2017

run ci

@Plamen5kov Plamen5kov merged commit 84555ae into master Mar 13, 2017
@Plamen5kov Plamen5kov deleted the plamen5kov/take_last_component_as_id branch March 14, 2017 09:11
@rosen-vladimirov
Copy link
Contributor

I do not understand what's the problem here and what do we fix. Can you provide more details? Ping @Plamen5kov , @pkoleva

@Plamen5kov
Copy link
Contributor Author

Plamen5kov commented Mar 15, 2017

@rosen-vladimirov to answer your question:
For android:
https://developer.android.com/studio/build/application-id.html

It must have at least two segments (one or more dots).
Each segment must start with a letter.
All characters must be alphanumeric or an underscore [a-zA-Z0-9_].

For iOS
https://developer.apple.com/library/content/documentation/General/Conceptual/DevPedia-CocoaCore/AppID.html

For an explicit App ID to match an app, the Team ID in the App ID must equal the Team ID associated with the app, and the bundle ID search string must equal the bundle ID for the app. The bundle ID is a unique identifier that identifies a single app and cannot be used by other teams.

There's no mention of maximum length restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants