Respect runtime version written in package json #2594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsvetanMilanov
suggested changes
Mar 9, 2017
| @@ -67,6 +67,10 @@ export class PlatformService extends EventEmitter implements IPlatformService { | |||
| } | |||
|
|
|||
| let platformData = this.$platformsData.getPlatformData(platform, projectData); | |||
| let currentPlatformData: any = this.$projectDataService.getNSValue(projectData.projectDir, platformData.frameworkPackageName); | |||
There was a problem hiding this comment.
this.$projectDataService.getNSValue can return null can you add check if it is null before you try to access currentPlatformData[constants.VERSION_STRING]
There was a problem hiding this comment.
Added a check on the line below, nice catch 🎣
Plamen5kov
reviewed
Mar 9, 2017
added 2 commits
March 9, 2017 11:39
Instead of always installing the latest runtime version, respect the one written in `package.json` `nativescript` key.
Mitko-Kerezov
force-pushed
the
kerezov/respect-runtime-version
branch
from
666cb61 to
ef24226
Compare
|
Ping @TsvetanMilanov with fixed comments and @Plamen5kov with added tests |
|
👍 after green build |
TsvetanMilanov
approved these changes
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always installing the latest runtime version, respect the one written in
package.jsonnativescriptkey.Ping @TsvetanMilanov @rosen-vladimirov @Plamen5kov