Rollback package.json if plugin installation fails #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Feb 14, 2017
lib/npm-installation-manager.ts
Outdated
| @@ -52,7 +50,7 @@ export class NpmInstallationManager implements INpmInstallationManager { | |||
| return this.installCore(packageToInstall, pathToSave, version, dependencyType).wait(); | |||
| } catch (error) { | |||
| this.$logger.debug(error); | |||
| this.$errors.fail("%s. Error: %s", NpmInstallationManager.NPM_LOAD_FAILED, error); | |||
| this.$errors.fail("%s", error); | |||
There was a problem hiding this comment.
this should be just throw error.
$errors.fail is usable only when we change the error itself, which is not the current case.
throw error when npm-installation-manager install fails
petekanev
force-pushed
the
pete/plugin-install-fail-rollback-251
branch
from
d94059f to
5f44f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement rollback of package.json contents of project if npm installation fails for whatever reason during installation of a NS plugin or platform.
Addresses #2487
master-based PR: #2531