stop gradle daemons when removing platform #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plamen5kov
suggested changes
Feb 14, 2017
lib/services/platform-service.ts
Outdated
| } | ||
| } | ||
|
|
||
| private async gradleStop(projectRoot: string): Promise<ISpawnResult> { |
There was a problem hiding this comment.
looks great, just move logic to android-project-service.ts, and call through platformData.platformProjectService...
petekanev
force-pushed
the
pete/stop-daemons-platform-remove
branch
from
fb7dff4 to
6949b63
Compare
petekanev
force-pushed
the
pete/stop-daemons-platform-remove
branch
from
6949b63 to
68109f1
Compare
Plamen5kov
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The android runtime (3.0) has had its gradle wrapper version updated where daemon processes are used by default.
Daemons are used to prevent the overhead of having to initialize the JVM on every build command, thus lowering the build time dramatically. The fact that the process remains alive appears to be a problem in Windows environments as the daemon locks the
platforms/androiddirectory.The changes in this PR ensure that the currently running daemons will be terminated, and the lock over the platforms directory released, so that it may be freely removed.
Addresses #2528