fix for #2460 #2465
Merged
fix for #2460 #2465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plamen5kov
force-pushed
the
plamen5kov/add_framework_files_ios
branch
from
d8d9a3c to
4717739
Compare
rosen-vladimirov
approved these changes
Jan 31, 2017
lib/services/plugins-service.ts
Outdated
| @@ -109,8 +109,8 @@ export class PluginsService implements IPluginsService { | |||
|
|
|||
| let appFolderExists = this.$fs.exists(path.join(platformData.appDestinationDirectoryPath, constants.APP_FOLDER_NAME)); | |||
| if (appFolderExists) { | |||
| this.preparePluginScripts(pluginData, platform); | |||
| this.preparePluginNativeCode(pluginData, platform); | |||
| await this.preparePluginScripts(pluginData, platform); | |||
There was a problem hiding this comment.
preparePluginScripts returns void, not Promise, so no need to use await here.
Plamen5kov
force-pushed
the
plamen5kov/add_framework_files_ios
branch
from
4717739 to
d9b710a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
See more in this issue.
Because of the way promises are executed, a new project was created twice and was overridden twice with only one framework file being added each time. The proper implementation reads the previously changed .proj file and augments it with the new .framework file.
Fix for: #2460