Skip to content

Remove --get-port flag #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Remove --get-port flag #2440

merged 1 commit into from
Jan 18, 2017

Conversation

ivanbuhov
Copy link
Contributor

@ivanbuhov ivanbuhov commented Jan 18, 2017

--get-port flag was previously used only by the VSCode extension to print the forwarded debug port. This PR removes the flag and prints the debug port on every run of tns debug android.

Depends on: telerik/mobile-cli-lib#878

@ivanbuhov ivanbuhov force-pushed the buhov/remove-get-port branch 3 times, most recently from 837a70e to 9eb06f1 Compare January 18, 2017 11:59
@ivanbuhov ivanbuhov force-pushed the buhov/remove-get-port branch from 9eb06f1 to 65e710a Compare January 18, 2017 12:33
@ivanbuhov ivanbuhov merged commit 2dbc948 into release Jan 18, 2017
@ivanbuhov ivanbuhov deleted the buhov/remove-get-port branch January 18, 2017 13:07
rosen-vladimirov pushed a commit that referenced this pull request Jan 23, 2017
rosen-vladimirov added a commit that referenced this pull request Jan 24, 2017
* Fixed: tns update crashes with error message (#2421)

* Fixed: the app doesn't exit when using --release and --justlaunch (#2423)

* Fixed: debug exits unexpected when using --chrome and --watch options (#2426)

* Fixed: test command fails with exception (#2428)

* Fixed: getfile/putfile operate with global files (not local ones) (#2434)

* Remove --get-port flag (#2440)

* Deprecate support for Node.js 4 (#2444)

Deprecate support for Node.js `4.x.x` by adding message that users will see each time when they execute any command and their Node.js version is `4.x.x`.

* Updated CLI documentation after behavior changes in run command (#2435)

* Updated CLI documentation after behavior changes in run command

* Remove usages of  in help content.

* Update message for livesync deprecation as it should not contain concrete release version

* Add source-map dependency and it's types. Fix typescript error

Add source-map dependency and typings for it. Previously CLI used it from `lib/common/vendor` dir, but it has npm package for a long time and it's better to use it instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants