Fix support for Node.js 4 #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the code is transpiled to ES6, spread operator from TypeScript is transpiled to spread operator in JavaScript.
However this usage is not available in Node.js 4:
```TypeScript
let { normalizedPropertyName, projectConfigurations } = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations);
// Replaced with:
let data = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations),
normalizedPropertyName = data.normalizedPropertyName,
projectConfigurations = data.projectConfigurations;
```
This is limitation of Node.js 4 itself. Spread operator is not available there (it's available only for arrays, i.e.
```JavaScript
const arr = [ 1, 2, 3 ]
console.log([ 0, ...arr ]);
[ 0, 1, 2, 3 ]
```
vchimev
approved these changes
Jan 12, 2017
TomaNikolov
pushed a commit
that referenced
this pull request
Jan 26, 2017
As the code is transpiled to ES6, spread operator from TypeScript is transpiled to spread operator in JavaScript.
However this usage is not available in Node.js 4:
```TypeScript
let { normalizedPropertyName, projectConfigurations } = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations);
// Replaced with:
let data = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations),
normalizedPropertyName = data.normalizedPropertyName,
projectConfigurations = data.projectConfigurations;
```
This is limitation of Node.js 4 itself. Spread operator is not available there (it's available only for arrays, i.e.
```JavaScript
const arr = [ 1, 2, 3 ]
console.log([ 0, ...arr ]);
[ 0, 1, 2, 3 ]
```
rosen-vladimirov
added a commit
that referenced
this pull request
Jan 26, 2017
As the code is transpiled to ES6, spread operator from TypeScript is transpiled to spread operator in JavaScript.
However this usage is not available in Node.js 4:
```TypeScript
let { normalizedPropertyName, projectConfigurations } = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations);
// Replaced with:
let data = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations),
normalizedPropertyName = data.normalizedPropertyName,
projectConfigurations = data.projectConfigurations;
```
This is limitation of Node.js 4 itself. Spread operator is not available there (it's available only for arrays, i.e.
```JavaScript
const arr = [ 1, 2, 3 ]
console.log([ 0, ...arr ]);
[ 0, 1, 2, 3 ]
```
rosen-vladimirov
added a commit
that referenced
this pull request
Jan 26, 2017
As the code is transpiled to ES6, spread operator from TypeScript is transpiled to spread operator in JavaScript.
However this usage is not available in Node.js 4:
```TypeScript
let { normalizedPropertyName, projectConfigurations } = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations);
// Replaced with:
let data = this.validateUpdatePropertyInfo(propertyName, propertyValues, configurations),
normalizedPropertyName = data.normalizedPropertyName,
projectConfigurations = data.projectConfigurations;
```
This is limitation of Node.js 4 itself. Spread operator is not available there (it's available only for arrays, i.e.
```JavaScript
const arr = [ 1, 2, 3 ]
console.log([ 0, ...arr ]);
[ 0, 1, 2, 3 ]
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the code is transpiled to ES6, spread operator from TypeScript is transpiled to spread operator in JavaScript.
However this usage is not available in Node.js 4:
This is limitation of Node.js 4 itself. Spread operator is not available there (it's available only for arrays, i.e.