Fixed: "tns emulate android" fails with a space in the name of the home directory #2413
Conversation
| } else { | ||
| this.$devicesService.initialize({ platform: platform, deviceId: this.$options.device }).wait(); | ||
| let found: Mobile.IDeviceInfo[] = []; | ||
| if (this.$devicesService.hasDevices) { |
There was a problem hiding this comment.
Why is this code required? devicesService will fail in case you pass --device invalidIdentifier and it does not find such identifier:
https://github.com/telerik/mobile-cli-lib/blob/master/mobile/mobile-core/devices-service.ts#L337
https://github.com/telerik/mobile-cli-lib/blob/master/mobile/mobile-core/devices-service.ts#L345
https://github.com/telerik/mobile-cli-lib/blob/master/mobile/mobile-core/devices-service.ts#L256
There was a problem hiding this comment.
This code is necessary because deployPlatform method calls $devicesService.execute method in order to deploy on all specified devices:
https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/platform-service.ts#L435
The execute method however starts the default emulator when there are no connected devices:
https://github.com/telerik/mobile-cli-lib/blob/9b2d88f4b23247e601fccb35be45c411ea3ddf87/mobile/mobile-core/devices-service.ts#L318
All this is not expected when executing tns emulate <platform> --device <device_id>. The expected result is to fail with the following message:
"Cannot find device with name: <device_id>" as specified by our QAs. Note that this message is different from ERROR_NO_DEVICES message.
This code comes from PR #2412
tzraikov
force-pushed
the
raikov/fix-space-emulator-path
branch
from
6fd9dd3 to
326e0f2
Compare
tzraikov
force-pushed
the
raikov/fix-space-emulator-path
branch
from
326e0f2 to
9fa6755
Compare
Fixes #2380