Fixed: Confusing report for a problem with CocoaPods during installation #2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Jan 11, 2017
There was a problem hiding this comment.
Just to explain what's the real problem:
When user executes npm install -g nativescript, the global (-g) flag is valid for all consecutive calls to npm in the same process. As $npm.install uses child_process.spawn, the tns-ios package is installed globally instead of installing it in the specified directory.
That's why we have to set it to false.
|
Btw, shouldn't this target release branch? |
|
Created another PR in release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2363