Invoke gradle fullClean on android after removing a native plugin #2369
Conversation
petekanev
force-pushed
the
pete/clean-on-remove-native-plugin-android
branch
from
be389db to
3f6daa3
Compare
| } | ||
| return Future.fromResult(); | ||
| } | ||
|
|
||
| private cleanProject(projectRoot: string, options: string[]): void { |
There was a problem hiding this comment.
the method has async operation (.wait() ), so it must return IFuture<void> instead of void.
There was a problem hiding this comment.
If I wait() the asynchronous spawn, doesn't that mean that the method will execute synchronously, as the async operation is resolved within the method?
There was a problem hiding this comment.
Yes, but think of the async method in a C# manner:
You can use await only in methods marked as async.
Futures allow such inconsistency - to have .wait in a pure sync method, but it's a common practice to wrap your code in a Future, when anywhere in the body you are using .wait. Also Promises and async/await in TypeScript does not allow having await without the method being marked as async, so it will be easier to replace the IFuture with Promise in the method definition.
petekanev
force-pushed
the
pete/clean-on-remove-native-plugin-android
branch
from
3f6daa3 to
51da72b
Compare
petekanev
force-pushed
the
pete/clean-on-remove-native-plugin-android
branch
from
51da72b to
bc6fdf8
Compare
Depends on: NativeScript/android#664
Moved native plugin clean logic to android build.gradle. Now when removing a plugin with android libraries in the form of jars and aars, the android build directory is invalidated, such that a full build will be necessary the next time the project is ran.
Addresses #2270