Plamen5kov/respect shelljserrors #2364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests were failing because of invalid template, fixed the template so the tests work
| @@ -140,7 +140,8 @@ export class ProjectService implements IProjectService { | |||
|
|
|||
| shelljs.cp('-R', path.join(appSourcePath, "*"), appDestinationPath); | |||
| // Copy hidden files. | |||
| shelljs.cp('-R', path.join(appSourcePath, ".*"), appDestinationPath); | |||
| //TODO: plamen5kov: don't copy hidden files, until we find a reason to do it | |||
| // shelljs.cp('-R', path.join(appSourcePath, ".*"), appDestinationPath); | |||
There was a problem hiding this comment.
Strongly disagree here. Why you need a reason for already existing code? Either remove it or keep it in the way it works today. Also I can reverse the question - why wouldn't you copy all files from template? Hidden files could be part of the template, so... why not copying them? And last - on Windows they are not hidden at all.
there was code that used sed to replace __CFBUNDLEIDENTIFIER__ into the info.plist, but there's new logic that does the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow shelljs errors to be fatal and interrupt the execution of any command if necessary. The current implementation has accounted for several places where, the errors are expected and are handled accordingly.
One more thing is the minimal project template support version is upped from
1.3.0to1.5.0.This PR should be merged after: telerik/mobile-cli-lib#861