Fix $injector to resolve lambdas #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the transpilation had been changed to ES6 instead of ES5, there is a problem, when $injector should resolve lambdas. When they are transpiled to ES5, they are converted to functions. However in ES6 they are still lambdas and current `annotate` method does not work correctly. Fix the regex that's used for the parsing and add unit tests for the failing cases.
rosen-vladimirov
force-pushed
the
vladimirov/fix-lambdas-resolve
branch
from
32b5328 to
c91c090
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the transpilation had been changed to ES6 instead of ES5, there is a problem, when $injector should resolve lambdas.
When they are transpiled to ES5, they are converted to functions. However in ES6 they are still lambdas and current
annotatemethod does not work correctly.Fix the regex that's used for the parsing and add unit tests for the failing cases.