Use https for submodule initialization #2324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the submodule is initialized via ssh. This way the command `git submodule update --init` will work only for users who have write access to mobile-cli-lib. This also requires custom logic when travis is used. In current implementation, travis automatically calls `npm install` before executing the scripts, but at this point the submodule is not initialized yet (as we have declared submodules variable to false). So the `npm install` executed by travis, will fail in case the postinstall script uses some code from the submodule. In order to fix this two changes are applied: - change the sumodule to be used over https instead of ssh. - modify .travis.yml to use submodule correctly and remove two manual steps which are executed by travis by default, there's no need the execute them again. NOTE: In case you have two-factor authentication, you'll not be able to commit to mobile-cli-lib over https. In this case you have to: - remove content of lib/common dir - clone over ssh: `$ git clone [email protected]:telerik/mobile-cli-lib.git .` (you must be inside lib/common dir).
|
run ci |
|
Ping @ErjanGavalji |
|
run ci |
TsvetanMilanov
approved these changes
Dec 7, 2016
|
Agreed, the dumb protocol of git has proven as the better option for submodules. That will be true until people learn caring about their security and using SSH :) |
ErjanGavalji
approved these changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the submodule is initialized via ssh. This way the command
git submodule update --initwill work only for users who have write access to mobile-cli-lib.This also requires custom logic when travis is used. In current implementation, travis automatically calls
npm installbefore executing the scripts, but at this point the submodule is not initialized yet (as we have declared submodules variable to false).So the
npm installexecuted by travis, will fail in case the postinstall script uses some code from the submodule.In order to fix this two changes are applied:
NOTE: In case you have two-factor authentication, you'll not be able to commit to mobile-cli-lib over https. In this case you have to:
$ git clone [email protected]:telerik/mobile-cli-lib.git .(you must be inside lib/common dir).