Skip to content

Fixes typo in "--avd is no longer supported." message #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hegdeashwin
Copy link

@hegdeashwin hegdeashwin commented Nov 22, 2016

I found this typo while setting up Nativescript Angular app with Android emulator

@ns-bot
Copy link

ns-bot commented Nov 22, 2016

Can one of the admins verify this patch?

@hegdeashwin
Copy link
Author

hegdeashwin commented Nov 22, 2016

Build error

Note: You may wish to enable the suppressImplicitAnyIndexErrors grunt-ts option to allow dynamic property access by index. This will suppress TypeScript error TS7017.
2199 non-emit-preventing type warnings
Error: tsc return code: 2

As per my finding in grunt-ts plugin, setting suppressImplicitAnyIndexErrors: true and failOnTypeErrors: false in Gruntfile.js fixes the above error triggering from task grunt:ts devall grunt lint & grunt tasks are passing in my local environment

Please let me know if its Ok for you guys; if I update this pull-request to set these options.

@enchev
Copy link
Contributor

enchev commented Nov 24, 2016

run ci

@enchev enchev mentioned this pull request Nov 24, 2016
@enchev
Copy link
Contributor

enchev commented Nov 24, 2016

Hey @hegdeashwin,

Thank you very much! There is a problem with this pull request and I've made new with your change. I'm closing this.

@enchev enchev closed this Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants