Keep track of prepared plugins and avoid unnecessary cleans. #2194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plamen5kov
reviewed
Nov 4, 2016
| assert.deepEqual({}, pluginPrepare.preparedDependencies); | ||
| }); | ||
|
|
||
| it("skips prepare if every plugin prepared", () => { |
There was a problem hiding this comment.
this test is same as the one above
|
👍 after deleting unnecessary test |
hdeshev
force-pushed
the
hdeshev/plugin-clean
branch
2 times, most recently
from
aa3fe6d to
44d115e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new dependency analysis algorithm always passes all plugins and we need to keep track of prepared ones, so that we don't clean and prepare everything unnecessary (most painful on Android).
Related to #2110, #2152
Ping @Plamen5kov