Unzip NativeScript Inspector Application #2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly $npmInstallationManager.install does not install the package, it only inserts it in the cache through the npm cache add command Since npm cache add command does not execute scripts our posinstall script that extract the Inspector Application does not execute as well So until this behavior is changed this ugly workaround should not be deleted
|
@Plamen5kov promised to fix this ugliness soon |
rosen-vladimirov
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly $npmInstallationManager.install does not install the package, it only inserts it in the cache through the npm cache add command
Since npm cache add command does not execute scripts our posinstall script that extract the Inspector Application does not execute as well
So until this behavior is changed this ugly workaround should not be deleted