Extract tns-core-modules on root level of tns_modules #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdeshev
approved these changes
Oct 26, 2016
| @@ -30,6 +30,8 @@ export class TnsModulesCopy { | |||
| Future.wait(deleteFilesFutures); | |||
|
|
|||
| shelljs.rm("-rf", path.join(tnsCoreModulesResourcePath, "node_modules")); | |||
| shelljs.cp("-Rf", path.join(tnsCoreModulesResourcePath, "*"), this.outputRoot); | |||
There was a problem hiding this comment.
Add a scare comment why we're doing all this crap, and we have a deal 😁
petekanev
force-pushed
the
pete/copy-node_modules
branch
from
857f617 to
d140a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to partially revert changes made in #2152 such that
tns-core-modulessubmodules will once again be copied directly intotns_modules.@hdeshev @dtopuzov