Skip to content

Add snapshot plugin to project package.json #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add snapshot plugin to project package.json #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/services/project-data-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ export class ProjectDataService implements IProjectDataService {
"description": "NativeScript Application",
"license": "SEE LICENSE IN <your-license-filename>",
"readme": "NativeScript Application",
"repository": "<fill-your-repository-here>"
"repository": "<fill-your-repository-here>",
"devDependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the code is here? It can be added to the templates as all devDependencies from the template will be added to the currently created project:
https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/project-service.ts#L76

https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/project-service.ts#L100-L102

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I prefer to add this to the templates. @jasssonpet what do you think?

Copy link
Contributor Author

@jasssonpet jasssonpet Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move it to the templates, but are we sure there aren't any templates outside the NativeScript organization? Or should I add it to the hello-world template and it will be copied like the App_Resources are?

Copy link
Contributor

@enchev enchev Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made pull requests for all three templates. No other templates outside of the organization
NativeScript/template-hello-world-ng#24
NativeScript/template-hello-world#53
NativeScript/template-hello-world-ts#14

"nativescript-dev-android-snapshot": "^0.*.*"
}
}).wait();
}

Expand Down