Added email registration for NativeScript mailing lists as post install step #2134
Conversation
tzraikov
force-pushed
the
raikov/email-registration-2
branch
from
085c04d to
d25f412
Compare
|
|
||
| export class PostInstallCliCommand extends PostInstallCommand { | ||
|
|
||
| private fileSystem: IFileSystem; |
There was a problem hiding this comment.
This property is just assigned, it's not used anywhere, consider removing it.
|
|
||
| public execute(args: string[]): IFuture<void> { | ||
| return (() => { | ||
| super.execute(args).wait(); |
There was a problem hiding this comment.
mixed spaces and tabs
| this.logger.out("Leave your e-mail address here to subscribe for NativeScript newsletter and product updates, tips and tricks:"); | ||
| let email = this.getEmail("(press Enter for blank)").wait(); | ||
| this.sendEmail(email); | ||
| this.$userSettingsService.saveSetting("EMAIL_REGISTERED", true).wait(); |
There was a problem hiding this comment.
if the sendEmail command fails, next time when user installs NS CLI, he'll be prompted again (as the EMAIL_REGISTERED value will never be written in the settings file), is this expected? In case not, you can swap the two lines above.
| } | ||
|
|
||
| private shouldAskForEmail(): boolean { | ||
| if (!helpers.isInteractive() || process.env.CLI_NOPROMPT === "1" || this.$userSettingsService.getSettingValue("EMAIL_REGISTERED").wait()) { |
There was a problem hiding this comment.
this could be simplified to:
return helpers.isInteractive() && process.env.CLI_NOPROMPT !== "1" && !this.$userSettingsService.getSettingValue("EMAIL_REGISTERED").wait();But I do not insist changing it.
| @@ -0,0 +1,91 @@ | |||
| import {PostInstallCommand} from "../common/commands/post-install"; | |||
| let emailValidatorModule = require('email-validator'); | |||
There was a problem hiding this comment.
you can include the email-validator.d.ts file from here:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/email-validator/email-validator.d.ts
Which will allow you to use
import * as emailValidator from "email-validator";But this is not a merge stopper :)
| @@ -0,0 +1,91 @@ | |||
| import {PostInstallCommand} from "../common/commands/post-install"; | |||
| let emailValidatorModule = require('email-validator'); | |||
| let queryString = require('querystring'); | |||
There was a problem hiding this comment.
you can use
import * as querystring from "querystring";
tzraikov
force-pushed
the
raikov/email-registration-2
branch
3 times, most recently
from
06aebfd to
4bde8cc
Compare
tzraikov
force-pushed
the
raikov/email-registration-2
branch
from
4bde8cc to
402e33f
Compare
#2128