Fixed: Livesync not working when started for the first time on device #2123
Conversation
tzraikov
force-pushed
the
raikov/fix-first-time-livesync
branch
from
4bc8b4a to
08fa8d7
Compare
| @@ -29,10 +29,11 @@ class IOSPlatformLiveSyncService extends PlatformLiveSyncServiceBase { | |||
| let localToDevicePaths = this.$projectFilesManager.createLocalToDevicePaths(deviceAppData, projectFilesPath, null, this.liveSyncData.excludedProjectDirsAndFiles); | |||
| let afterSyncAction: () => IFuture<void>; | |||
|
|
|||
| this.transferFiles(deviceAppData, localToDevicePaths, this.liveSyncData.projectFilesPath, true).wait(); | |||
There was a problem hiding this comment.
how will this code work in case the application is not installed on device? Where will it transfer the files as there's no sandbox on device (/Library/Application Support directory for current app)?
There was a problem hiding this comment.
Actually this code executes after the application is installed on device. Note that the installed flag indicates whether the tryInstallApplication installed the app. If it returns false, then the app was already installed.
There was a problem hiding this comment.
The idea is to synchronize all files the first time when livesync is called, because all consequent updates will be partial and it will bring inconsistence. The app will not be able to find all js files and it will crash.
There was a problem hiding this comment.
Ok, the name installed confused me.
Fixes #2072