A proper fix for all Ctrl+C issues #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzraikov
force-pushed
the
raikov/ctrl-c
branch
2 times, most recently
from
1da83d1 to
188041d
Compare
rosen-vladimirov
approved these changes
Sep 19, 2016
| }).future<void>()(); | ||
| } | ||
|
|
||
| private wireDebuggerClient(factory: () => net.Socket): IFuture<void> { | ||
| private wireDebuggerClient(device: Mobile.IiOSDevice): IFuture<void> { |
There was a problem hiding this comment.
You can make the device argument not mandatory
private wireDebuggerClient(device?: Mobile.IiOSDevice): IFuture<void> {This way you will not have to pass null when calling the method without device.
tzraikov
force-pushed
the
raikov/ctrl-c
branch
from
188041d to
79d757a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tns run ios- on devicetns livesync ios --watchtns debug --watch.. etc
Depends on:
telerik/mobile-cli-lib#807