Skip to content

Fixed: VisualStudioCode hangs when executing Sync on iOS action #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Fixed: VisualStudioCode hangs when executing Sync on iOS action #1993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/commands/debug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
return (() => {
let projectData: IProjectData = this.$injector.resolve("projectData");

this.$logger.info(`Successfully synced application ${deviceAppData.appIdentifier} on device ${deviceAppData.device.deviceInfo.identifier}.`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is repeated in the platform-livesync-service-base, so I vote for moving both messages into the livesync-service. This way the chance to change/delete it would be lower.
Also it would be nice to add a comment why this message is so important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. I had some issues doing this in the current implementation of the livesync service. That is why I will do this in another commit.


this.debugService.debugStop().wait();

let applicationId = deviceAppData.appIdentifier;
Expand Down