Do not force LaunchScreen when adding AndroidManifest.xml in old projects #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanayotCankov
force-pushed
the
cankov/dont-force-launchscreen
branch
from
1ac2b23 to
70d8eae
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some arcane projects have no AndroidManifest.xml in App_Resources. When we add the new AndroidManifets it requires LaunchScreenTheme resources. Since these project had no splashscreen when they were created we had decided that we do not want to force feed them splash screens and sanitize the theme attribute and default theme meta in the AndroidManifest when we are coping it from the default template.