Skip to content

Added support for Xcode 8 and iOS 10 #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Added support for Xcode 8 and iOS 10 #1961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/services/ios-project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
} else {
args = basicArgs.concat([
"-sdk", "iphonesimulator",
"-arch", "i386",
'VALID_ARCHS="i386"',
"-arch", "x86_64",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work with XCode 7 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Xcode 7.3.1

"VALID_ARCHS=i386 x86_64",
"CONFIGURATION_BUILD_DIR=" + path.join(projectRoot, "build", "emulator"),
"CODE_SIGN_IDENTITY="
]);
Expand Down Expand Up @@ -834,7 +834,7 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
this.$errors.failWithoutHelp(`The bundle at ${libraryPath} does not contain a valid static library in the '.a' file format.`);
}

let expectedArchs = ["armv7", "arm64", "i386"];
let expectedArchs = ["armv7", "arm64", "i386", "x86_64"];
let archsInTheFatFile = this.$childProcess.exec("lipo -i " + libraryPath).wait();

expectedArchs.forEach(expectedArch => {
Expand Down