Add archive and exportArchive for iOS. #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
PanayotCankov
force-pushed
the
cankov/xcarchive-publish
branch
3 times, most recently
from
2c85966 to
76291fe
Compare
| @@ -146,7 +124,22 @@ export class ITMSTransporterService implements IITMSTransporterService { | |||
| temp.track(); | |||
| let destinationDir = temp.mkdirSync("ipa-"); | |||
| this.$fs.unzip(ipaFileFullPath, destinationDir).wait(); | |||
| let plistObject = this.$bplistParser.parseFile(path.join(destinationDir, "Payload", "iossampleapp.app", "Info.plist")).wait(); | |||
| // WHAT THE FUCK! WHAT THE FUCKING FUUUCK! | |||
Tests for tns appstore with xcode archives Added script that runs tsc --watch and upon changes runs mocha, good for unit test writing Let us unit test easier, no references .d.ts anymore, no use strict anymore (ts will add this automagically) Fixing unreachable code Add tests for IOSProjectService archive and exportArchive Fix ITMS hardcoded app, xcodebuild archive -archivePath expects scheme, not target Add shared schema from the project template
PanayotCankov
force-pushed
the
cankov/xcarchive-publish
branch
from
76291fe to
15c7919
Compare
|
👍 I love the tests |
|
Aside the hardcoded app name in the ITMSTransporterService it was pleasure working with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1790
Tests for tns appstore with xcode archives
Added script that runs tsc --watch and upon changes runs mocha, good for unit test writing
Let us unit test easier, no references .d.ts anymore, no use strict anymore (ts will add this automagically)
Fixing unreachable code
Add tests for IOSProjectService archive and exportArchive
Added
npm run mochaandnpm run tscto runtscandmochafrom dev dependencies.Added
npm run test-watchscript that runstsc --watchand on successful compilation runs alsomochafrom dev dependencies