Create Android default emulator #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enchev
force-pushed
the
setup-scripts
branch
4 times, most recently
from
7f62073 to
62de8db
Compare
| @@ -105,6 +105,13 @@ echo y | cmd /c "$androidExecutable" update sdk --filter "android-23" --all --no | |||
| echo y | cmd /c "$androidExecutable" update sdk --filter "build-tools-23.0.2" --all --no-ui | |||
| echo y | cmd /c "$androidExecutable" update sdk --filter "extra-android-m2repository" --all --no-ui | |||
|
|
|||
| echo y | $ANDROID_HOME/tools/android update sdk --filter extra-intel-Hardware_Accelerated_Execution_Manager --all --no-ui | |||
|
|
|||
| $haxmSilentInstaller = [io.path]::combine($env:ANDROID_HOME, "extras", "intel", "Hardware_Accelerated_Execution_Manager", "silent_install.sh") | |||
There was a problem hiding this comment.
isn't it silent_install.bat
| @@ -105,6 +105,20 @@ echo y | cmd /c "$androidExecutable" update sdk --filter "android-23" --all --no | |||
| echo y | cmd /c "$androidExecutable" update sdk --filter "build-tools-23.0.2" --all --no-ui | |||
| echo y | cmd /c "$androidExecutable" update sdk --filter "extra-android-m2repository" --all --no-ui | |||
|
|
|||
| if ((Read-Host "Do you want to install Android emulator?") -eq 'y') { | |||
There was a problem hiding this comment.
You can use the Install function here instead of asking the user explicitly.
The purpose of the Install function is that the user may specify that that everything should be installed with no further questions.
There was a problem hiding this comment.
We've decided that we want to ask explicitly if Android emulator should be installed and what kind of emulator will be used. We don't want to install both emulators.
| execute("echo y | #{android_executable} update sdk --filter android-23 --all --no-ui", "There seem to be some problems with the Android configuration") | ||
| execute("echo y | #{android_executable} update sdk --filter build-tools-23.0.2 --all --no-ui", "There seem to be some problems with the Android configuration") | ||
| execute("echo y | #{android_executable} update sdk --filter extra-android-m2repository --all --no-ui", "There seem to be some problems with the Android configuration") | ||
| execute("echo y | #{android_executable} update sdk --filter platform-tools --all --no-ui", "#{error_msg}") |
There was a problem hiding this comment.
you can safely use the variable itself without expanding it inside a string
execute("echo y | #{android_executable} update sdk --filter platform-tools --all --no-ui", error_msg)
|
👍 |
1 similar comment
|
👍 |
| execute("echo y | $ANDROID_HOME/tools/android update sdk --filter extra-intel-Hardware_Accelerated_Execution_Manager --all --no-ui", error_msg) | ||
|
|
||
| haxm_silent_installer = File.join(ENV["ANDROID_HOME"], "extras", "intel", "Hardware_Accelerated_Execution_Manager", "silent_install.sh") | ||
| execute("#{haxm_silent_installer}", "There seem to be some problems with the Android configuration") |
There was a problem hiding this comment.
This can be re-written as:
execute(haxm_silent_installer, error_msg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1731