Skip to content

XML validation fixed #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2016
Merged

XML validation fixed #1780

merged 2 commits into from
May 27, 2016

Conversation

enchev
Copy link
Contributor

@enchev enchev commented May 27, 2016

Related to #1777

@rosen-vladimirov
Copy link
Contributor

Maybe you should update this test as it expects to return false when there's invalid .xml, but with current changes the code will throw error
https://github.com/NativeScript/nativescript-cli/blob/master/test/platform-service.ts#L340

@enchev enchev force-pushed the xml-validation branch 3 times, most recently from 4ef6385 to 27c2944 Compare May 27, 2016 12:08
@enchev
Copy link
Contributor Author

enchev commented May 27, 2016

@rosen-vladimirov done!

@rosen-vladimirov
Copy link
Contributor

👍

@enchev enchev force-pushed the xml-validation branch 2 times, most recently from 0c9669e to 13c955a Compare May 27, 2016 14:03
@enchev enchev merged commit bd4a2a9 into master May 27, 2016
@enchev enchev deleted the xml-validation branch May 27, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enchev @rosen-vladimirov