Fix add android platform dependencies #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // The plugin version is not valid. Check node_modules for the valid version. | ||
| if (!cleanedVerson) { | ||
| dependencyVersionInProject = this.$fs.exists(path.join(this.$projectData.projectDir, "node_modules", dependency.name, "package.json")).wait() && |
There was a problem hiding this comment.
"node_modules" -> constants.NODE_MODULES_FOLDER_NAME
"package.json" -> constants.PACKAGE_JSON_FILE_NAME
When checking if platform dependency is installed in the current project before adding the platform need to check if the current version is valid or check in the node_modules directory for the installed plugin version.
TsvetanMilanov
force-pushed
the
milanov/fix-add-android-platform-dependencies
branch
from
8863411 to
317e180
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if platform dependency is installed in the current project before adding the platform need to check if the current version is valid or check in the node_modules directory for the installed plugin version.