Add check for Podfile before preparing platform #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing iOS need to check if any plugin requires Cocoapods to be installed and configured correctly. If plugin contains podfile in the platforms/ios directory and Cocoapods is not installed or not configured correctly the platform prepare should fail.
| _.each(this.$pluginsService.getAllInstalledPlugins().wait(), (pluginData: IPluginData) => { | ||
| if (this.$fs.exists(path.join(pluginData.pluginPlatformsFolderPath(platform), "Podfile")).wait() && | ||
| !this.$sysInfo.getSysInfo(this.$staticConfig.pathToPackageJson).wait().cocoapodVer) { | ||
| this.$errors.failWithoutHelp(`${pluginData.name} has Podfile and you don't have Cocoapods installed or it is not configured correctly. Please install Cocoapods and configure it correctly.`); |
There was a problem hiding this comment.
Please verify Cocoapods can work on your machine maybe
|
👍 |
When preparing iOS and merging xcconfig files if the project requires xcodeproj to be used (Cocoapods version < 1.0.0 and Xcode version >= 7.3) need to check if xcodeproj is available and fail if it's not.
TsvetanMilanov
force-pushed
the
milanov/check-for-podfile-on-prepare
branch
from
dcab014 to
82a2bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing iOS need to check if any plugin requires Cocoapods to be installed and configured correctly. If plugin contains Podfile in the platforms/ios directory and Cocoapods is not installed or not configured correctly the platform prepare should fail.
This fixes #1734
When preparing iOS and merging xcconfig files if the project requires xcodeproj to be used (Cocoapods version < 1.0.0 and Xcode version >= 7.3) need to check if xcodeproj is available and fail if it's not.