Remove node_modules when preparing nativescript plugins #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing nativescript plugins, we copy the whole directory to the native project. This leads to a problem that node_modules dir of such plugins is also copied, while it should be flattened. CLI had already flatten it, but the copy of node_modules is never deleted and we receive `.aar` files in iOS projects for example.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing nativescript plugins, we copy the whole directory to the native project.
This leads to a problem that node_modules dir of such plugins is also copied, while it should be flattened.
CLI had already flatten it, but the copy of node_modules is never deleted and we receive
.aarfiles in iOS projects for example.