Fix build for iOS #1692
Merged
Fix build for iOS #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -677,6 +677,13 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| let cocoapodsVer = this.$sysInfo.getSysInfo(this.$staticConfig.pathToPackageJson).wait().cocoapodVer, | |||
| xcodeVersion = this.$xcodeSelectService.getXcodeVersion().wait(); | |||
|
|
|||
| if(cocoapodsVer && !semver.valid(cocoapodsVer)) { | |||
There was a problem hiding this comment.
This could be shortened to !semver.valid(cocoapodsVer) only
|
👍 after fixing minor comment |
Cocoapods have versions like 1.0.0.beta.8, which are not valid semver versions. Use only the major.minor.patch part of the versions as all 1.0.0 betas work correctly with XCode 7.3
Revert special code for XCode 7.2 that adds `-destination` flag when building for iOS Simulator. Revert to original code, as it's working fine with all other XCode versions.
rosen-vladimirov
force-pushed
the
vladimirov/fix-cocoapods
branch
from
964d90b to
1c2d617
Compare
rosen-vladimirov
changed the title
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cocoapods have versions like 1.0.0.beta.8, which are not valid semver versions.
Use only the major.minor.patch part of the versions as all 1.0.0 betas work correctly with XCode 7.3
Revert special code for XCode 7.2 that adds
-destinationflag when building for iOS Simulator. Revert to original code, as it's working fine with all other XCode versions.