Use xcproj if needed to fix .pbxproject format #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
| @@ -585,7 +595,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| this.$logger.warn(`Podfile contains more than one post_install sections. You need to open ${this.projectPodFilePath} file and manually resolve this issue.`); | |||
| } | |||
|
|
|||
| let pbxprojFilePath = path.join(this.platformData.projectRoot, this.$projectData.projectName + IOSProjectService.XCODE_PROJECT_EXT_NAME, "xcuserdata"); | |||
| let pbxprojFilePath = path.join(this.xcodeprojPath, "xcuserdata"); | |||
There was a problem hiding this comment.
why is it called pbxprojFilePath?
Mitko-Kerezov
force-pushed
the
kerezov/pbxproject-format
branch
2 times, most recently
from
18fceea to
751dd3e
Compare
|
👍 |
CocoaPods < 1.0.0 does not support Xcode 7.3 yet and leaves all .pbxprojects in XML plist format instead of the ASCII plist one. Use xcproj if the user's configuration requires it to fix the .pbxproject's format.
Mitko-Kerezov
force-pushed
the
kerezov/pbxproject-format
branch
from
751dd3e to
46e6219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CocoaPods < 1.0.0 does not support Xcode 7.3 yet and leaves all .pbxprojects in XML plist format instead of the ASCII plist one. Use xcproj if the user's configuration requires it to fix the .pbxproject's format.
Merge after telerik/mobile-cli-lib#646
Works #1639 around
Ping @rosen-vladimirov