Pass -destination only when on Xcode 7.2 #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teobugslayer
force-pushed
the
kerezov/destination-to-xcode-7.3
branch
from
5fa860b to
303789a
Compare
| // passing -destination apparently only works with Xcode 7.2+ | ||
| if (xcodeVersion.major && xcodeVersion.minor && | ||
| helpers.versionCompare(xcodeVersion, "7.2.0") < 0) { | ||
| additionalArgs = ["-arch", "i386", "VALID_ARCHS=\"i386\""]; |
There was a problem hiding this comment.
'VALID_ARCHS="i386"'
|
👍 |
teobugslayer
force-pushed
the
kerezov/destination-to-xcode-7.3
branch
from
303789a to
0a003b9
Compare
Keep old logic when dealing with Xcode < 7.2
teobugslayer
force-pushed
the
kerezov/destination-to-xcode-7.3
branch
from
0a003b9 to
f8bc86d
Compare
|
run ci |
1 similar comment
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep old logic when dealing with Xcode < 7.2
In addition fix bug with detecting specific versions of Xcode - e.g. 6.3
The condition
major <= 6 && minor < 3is not met if the Xcode version is 5.9 for example (theoretically)Re-targeted from #1687
Merge after telerik/mobile-cli-lib#645
Ping @rosen-vladimirov for a thoroguh review