Add devDependencies when adding Android platform #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @Mitko-Kerezov , @TsvetanMilanov , @ikoevska |
|
ping @Plamen5kov |
|
👍 the android-runtime already has this flag in master, so whenever you feel ready you can merge, so tests are run with CLI |
|
|
||
| private _sysInfoData: ISysInfoData; | ||
| private get sysInfoData(): ISysInfoData { | ||
| if(!this._sysInfoData) { |
There was a problem hiding this comment.
remove this if, getSysInfo is caching
|
👍 from @Mitko-Kerezov after fixing comments |
In order to support Static Binding Generation, we have to add some dev Dependencies to the project when platform Android is added. As some of them do not work with Nodejs 0.x, we have to limit this functionality only to users who are using node 4.2.1 (the earliest version of 4.x that we support) or later. Show warning in case the user has older node version. Remove --staticBindings flag as it's turned on by default now.
rosen-vladimirov
force-pushed
the
vladimirov/add-android-dev-deps
branch
from
3e8dcdc to
3865b9b
Compare
|
run ci |
| this.$npm.install(`${dependency.name}@${dependency.version}`, this.$projectData.projectDir, npmConfig).wait() | ||
| ); | ||
| } else { | ||
| this.$logger.printMarkdown(` As you are using Node.js \`${this.sysInfoData.nodeVer}\` Static Binding Generator will be turned off.` + |
There was a problem hiding this comment.
Static Binding Generator will be turned off because you are using Node.js ${this.sysInfoData.nodeVer} .
To use the Static Binding Generator, upgrade your Node.js to ${AndroidProjectService.MIN_REQUIRED_NODEJS_VERSION_FOR_STATIC_BINDINGS} or later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support Static Binding Generation, we have to add some dev Dependencies to the project when platform Android is added.
As some of them do not work with Nodejs 0.x, we have to limit this functionality only to users who are using node 4.2.1 (the earliest version of 4.x that we support) or later.
Show warning in case the user has older node version.
Remove --staticBindings flag as it's turned on by default now.