Add a --bundle option that disables node_modules -> tns_modules update. #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdeshev
force-pushed
the
hdeshev/node_modules-bundle
branch
from
87eb145 to
b2c2136
Compare
|
Figured an easy way to add a test too! 🎈 |
| @@ -230,6 +230,7 @@ export class PlatformService implements IPlatformService { | |||
| let lastModifiedTime = this.$fs.exists(appDestinationDirectoryPath).wait() ? | |||
| this.$fs.getFsStats(appDestinationDirectoryPath).wait().mtime : null; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Multiple blank lines are not allowed (this will fail the build)
hdeshev
force-pushed
the
hdeshev/node_modules-bundle
branch
from
b2c2136 to
d85d0f8
Compare
Delete <platform/app>/tns_modules, if present, and make sure we restore it on subsequent runs without the --bundle option set.
|
Fixed both the whitespace and Future issues. |
|
👍 |
|
By the way, when running with the Not sure if this should be a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete
<platform/app>/tns_modules, if present, and make sure we restore iton subsequent runs without the
--bundleoption set.Ping @rosen-vladimirov