Added check if project name starts with number when creating new proj… #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ensureValidName(projectName: string, validateOptions?: {force: boolean}): IFuture<void> { | ||
| return (() => { | ||
| if (validateOptions.force) { |
There was a problem hiding this comment.
Should be if (validateOptions && validateOptions.force) {
TsvetanMilanov
force-pushed
the
milanov/fix-create-project-name-validation
branch
3 times, most recently
from
e49ca89 to
618fe3c
Compare
| */ | ||
| interface IProjectNameService { | ||
| /** | ||
| * Ensures the passed project name is valid. If the project name is not valida prompts for actions. |
…ect. Created project name service with method to ensure the project name does not start with number or if it starts with number the client is informed about the consequences when building for Android. When invalid project name is entered the client gets warning about the problem and a prompt with choice to create the project with invalid name or to enter valid name. Added integration tests for the prompts logic. Added unit tests for the project name service.
TsvetanMilanov
force-pushed
the
milanov/fix-create-project-name-validation
branch
from
618fe3c to
ff2ae76
Compare
|
👍 awesome work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect.
Created project name service with method to ensure the project name does not start with number or if it starts with number the client is informed about the consequences when building for Android.
When invalid project name is entered the client gets warning about the problem and a prompt with choice to create the project with invalid name or to enter valid name.
Added integration tests for the prompts logic.
This fixes #1203