Replace plugin variables in all Android .xml files #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
| if (this.$fs.exists(pluginConfigurationFilePath).wait()) { | ||
| this.$pluginVariablesService.interpolate(pluginData, pluginConfigurationFilePath).wait(); | ||
| } | ||
| let files = this.$fs.enumerateFilesInDirectorySync(resourcesDestinationDirectoryPath, file => this.$fs.getFsStats(file).wait().isDirectory() || path.extname(file) === ".xml"); |
There was a problem hiding this comment.
You can extract ".xml" as a constant as it's also used in xml-validator
In case a plugin has plugin variable, during project preparation CLI replaces the usage of the variable in plugin's AndroidManifest with the value set in the current project's package.json. This is not enough, we have to set the variables in all plugin's .xml files, so the value could be used in resource and later read from the JAVA code. Enumarate plugin's files and replace plugin variables in all .xml files.
rosen-vladimirov
force-pushed
the
vladimirov/interpolate-all-android-files
branch
from
869bd74 to
d30b2ff
Compare
|
👍 |
|
run ci |
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 22, 2016
…-android-files Replace plugin variables in all Android .xml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a plugin has plugin variable, during project preparation CLI replaces the usage of the variable in plugin's AndroidManifest with the value set in the current project's package.json.
This is not enough, we have to set the variables in all plugin's .xml files, so the value could be used in resource and later read from the JAVA code.
Enumarate plugin's files and replace plugin variables in all .xml files.
#1634