Improve Setup Scripts #1616
Merged
Improve Setup Scripts #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # To run it inside a COMMAND PROMPT against the production branch (only one supported with self-elevation) use | ||
| # @powershell -NoProfile -ExecutionPolicy Bypass -Command "iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/NativeScript/nativescript-cli/production/setup/native-script.ps1'))" | ||
| # To run it inside a WINDOWS POWERSHELL console against the production branch (only one supported with self-elevation) use | ||
| # start-process -FilePath PowerShell.exe -NoNewWindow -Wait -ArgumentList "-NoProfile -ExecutionPolicy Bypass -Command iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/NativeScript/nativescript-cli/production/setup/native-script.ps1'))" |
There was a problem hiding this comment.
Well, you are inside a powershell, why are you running another one? What about simply executing:
iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/NativeScript/nativescript-cli/production/setup/native-script.ps1'))
?
Mitko-Kerezov
force-pushed
the
kerezov/setup-scripts
branch
2 times, most recently
from
470d30d to
4297adf
Compare
|
run ci |
Mitko-Kerezov
force-pushed
the
kerezov/setup-scripts
branch
4 times, most recently
from
48c459c to
646ae0f
Compare
Changes include: * Asking permission from user for every installation - this includes an `all` option for eliminating subsequent questions * Improved error handling - warning upon non-zero exit code, error if the command execution fails * Adding `-V` option for `sudo gem install cocoapods`. This triggers a verbose output * Outputting multiple license acceptances for android tools * Creating ~/.cocoapods directory in case it does not exist
Mitko-Kerezov
force-pushed
the
kerezov/setup-scripts
branch
from
646ae0f to
2882233
Compare
|
Ping @teobugslayer with fixed comments |
| $latestDotNetVersion = $dotNetVersions.GetEnumerator() | Sort-Object Version | Select-Object -Last 1 | ||
| $latestDotNetMajorNumber = $latestDotNetVersion.Version.Split(".")[0] | ||
| if ($latestDotNetMajorNumber -lt 4) { | ||
| Write-Host -ForegroundColor Red "Running this script requires at least a version 4.0 .NET framework installed" |
There was a problem hiding this comment.
From Iva: "To run this script, you need .NET 4.0 or later installed"
|
Fix the messages, squash the commits and merge it! 👍 and excellent work! |
added 2 commits
March 18, 2016 13:54
Changes include:
* Asking permission from user for every installation - this includes an `all` option for eliminating subsequent questions
* Improved error handling - warning upon non-zero exit code
* Initial check for latest .NET Framework installed - should be at least 4
* Check for correct Chocolatey installation
* Fixed the syntax in docs header on invoking the setup script from the command prompt
* Added example syntax in docs header for invoking the setup script from powershell itself
If `$ tns doctor` detects any problems prompt the user to open docs and/or to run the setup script for his OS (if available). Default answers to both questions set to NO for NON-interactive consoles automation purposes. Default answers are set to YES for interactive consoles.
Mitko-Kerezov
force-pushed
the
kerezov/setup-scripts
branch
from
2882233 to
ab2e132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Setup Scripts:
Mac:
alloption for eliminating subsequent questions-Voption forsudo gem install cocoapods. This triggers a verbose outputWindows:
alloption for eliminating subsequent questionsDoctor command:
Addresses some parts of NativeScript/NativeScript#1556
Ping @rosen-vladimirov and @teobugslayer