Fix livesync for iOS #1599
Merged
Fix livesync for iOS #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI is destroying the socket too early and so the runtime cannot handle the message that we've sent. As a result livesync is not working sometimes. When we sent message, the socket will always receive data as result. If it's error, the result will contain it. In any case, we should destroy the socket when data is received.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI is destroying the socket too early and so the runtime cannot handle the message that we've sent.
As a result livesync is not working sometimes.
When we sent message, the socket will always receive data as result. If it's error, the result will contain it.
In any case, we should destroy the socket when data is received.