Skip to content

Add support for custom platform templates #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

rosen-vladimirov
Copy link
Contributor

Add new option when adding platform: --platform-template. When it is
used, CLI will use the specified template instead of the default template
from the runtime. The path to the specified template will be saved in
project's package.json, so next time when platform is added, the same
template will be used.
In case when --platform-template is not passed, CLI will check the
package.json and if there's value for the template, it will be used.
Otherwise the default template from runtime will be used.

@rosen-vladimirov
Copy link
Contributor Author

original PR - #1566


Configures the current project to target the selected platform. <% if(isHtml) { %>When you add a target platform, the NativeScript CLI adds a corresponding platform-specific subdirectory under the platforms directory. This platform-specific directory contains the necessary files to let you build your project for the target platform.<% } %>
Configures the current project to target the selected platform. <% if(isHtml) { %>When you add a target platform, the NativeScript CLI adds a corresponding platform-specific subdirectory under the platforms directory. This platform-specific directory contains the necessary files to let you build your project for the target platform.<% } %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you add a target platform, the NativeScript CLI adds a corresponding platform-specific subdirectory
->
When you add a target platform, the NativeScript CLI creates a corresponding platform-specific subdirectory

@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/custom-native-templates branch from 2c52a34 to 1c0e366 Compare March 9, 2016 15:05
@@ -3,26 +3,28 @@ platform add

Usage | Synopsis
------|-------
Android latest runtime | `$ tns platform add android [--frameworkPath <File Path>] [--symlink] [--sdk <API Level>]`
Android selected runtime | `$ tns platform add android[@<Version>] [--frameworkPath <File Path>] [--symlink] [--sdk <API Level>]`
Android latest runtime | `$ tns platform add android [--frameworkPath <File Path>] [--symlink] [--sdk <API Level>] [--platformTemplate <Platform Template>]`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the kebap-case when documenting options and switches.

@teobugslayer
Copy link
Contributor

👍

Add new option when adding platform: `--platform-template`. When it is
used, CLI will use the specified template instead of the default template
from the runtime. The path to the specified template will be saved in
project's package.json, so next time when platform is added, the same
template will be used.
In case when `--platform-template` is not passed, CLI will check the
package.json and if there's value for the template, it will be used.
Otherwise the default template from runtime will be used.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/custom-native-templates branch from 1c0e366 to 2ce4b75 Compare March 9, 2016 15:20
rosen-vladimirov added a commit that referenced this pull request Mar 9, 2016
…emplates

Add support for custom platform templates
@rosen-vladimirov rosen-vladimirov merged commit 50b6685 into release Mar 9, 2016
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/custom-native-templates branch March 9, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants