Fix installation of runtime with next tag #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| // In some cases the package is not fully downloaded and there are missing directories | ||
| // Try removing the old package and add the real one to cache again | ||
| this.addCleanCopyToCache(packageName, version).wait(); | ||
| cachedPackageData = this.addCleanCopyToCache(packageName, version).wait(); |
There was a problem hiding this comment.
According to the interface, addCleanCopyToCache(packageName: string, version: string): IFuture<void>;, so this reassignment of cachedPackageData is pointless.
I'm guessing the interface is a bit off.
|
👍 after addressing comments |
Our npmInstallationManager is using the passed `next` string as a version and searches for directory called `next` in the npm cache. Instead it should use the real version. Fix this by getting the result of npm call addToCache, which returns object with information about cached package.
rosen-vladimirov
force-pushed
the
vladimirov/fix-next-runtime
branch
from
d18c984 to
b75a4e4
Compare
|
Are we documenting this somewhere? |
|
@ikoevska no, it should work this way. It's a bug that it didn't work :) |
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 7, 2016
Fix installation of runtime with next tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our npmInstallationManager is using the passed
nextstring as a version and searches for directory callednextin the npm cache.Instead it should use the real version. Fix this by getting the result of npm call addToCache, which returns object with information about cached package.
With this change you can call:
Fixes #1563