Delete /data/local/tmp/<app-identifier> file if exists on Android device #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| matchingFile = (listResult || "").match(regex); | ||
|
|
||
| if(matchingFile && matchingFile[0] && _.startsWith(matchingFile[0], '-')){ | ||
| this.device.adb.executeShellCommand(["rm", "-rf", deviceRootPath]).wait(); |
There was a problem hiding this comment.
in case it's a file, you do not need -r
There was a problem hiding this comment.
I would love to see some log.trace message here, informing that the file had been removed
nadyaA
force-pushed
the
natanasova/android-livesync-isit-folder
branch
from
f26da9e to
96d5b59
Compare
Livesync does not work when /data/local/tmp/<app-identifier> file exists on Android device. This happens when a file with name app-identifier exists in /data/local/tmp directory on device. In this case CLI is not able to create directory.
nadyaA
force-pushed
the
natanasova/android-livesync-isit-folder
branch
from
96d5b59 to
ec05674
Compare
|
👍 |
nadyaA
added a commit
that referenced
this pull request
Mar 2, 2016
…c-isit-folder Delete /data/local/tmp/<app-identifier> file if exists on Android device
| matchingFile = (listResult || "").match(regex); | ||
|
|
||
| // Check if there is already a file with deviceRootBasename. If so, delete it as it breaks LiveSyncing. | ||
| if(matchingFile && matchingFile[0] && _.startsWith(matchingFile[0], '-')){ |
There was a problem hiding this comment.
We do not need the last check! In case the symbol is not - there will be no match :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Livesync does not work when /data/local/tmp/ file exists on Android device.
This happens when a file with name app-identifier exists in /data/local/tmp directory on device. In this case CLI is not able to create directory.
#1416
ping @rosen-vladimirov @Mitko-Kerezov